Skip to content

GitLab

Switch branch/tag
  1. 26 Dec, 2009 1 commit
  3. 26 Nov, 2009 1 commit
  5. 18 Nov, 2009 1 commit
    • Eric Dumazet's avatar
      vlan: Precise RX stats accounting · 9793241f
      Eric Dumazet authored 
      
With multi queue devices, its possible that several cpus call
vlan RX routines simultaneously for the same vlan device.

We update RX stats counter without any locking, so we can
get slightly wrong counters.

One possible fix is to use percpu counters, to get precise
accounting and also get guarantee of no cache line ping pongs
between cpus.

Note: this adds 16 bytes (32 bytes on 64bit arches) of percpu
data per vlan device.
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9793241f
  7. 13 Nov, 2009 1 commit
  9. 29 Oct, 2009 1 commit
  11. 27 Oct, 2009 1 commit
    • Eric Dumazet's avatar
      vlan: allow null VLAN ID to be used · 05423b24
      Eric Dumazet authored 
      
We currently use a 16 bit field (vlan_tci) to store VLAN ID/PRIO on a skb.

Null value is used as a special value, meaning vlan tagging not enabled.
This forbids use of null vlan ID.

As pointed by David, some drivers use the 3 high order bits (PRIO)

As VLAN ID is 12 bits, we can use the remaining bit (CFI) as a flag, and
allow null VLAN ID.

In case future code really wants to use VLAN_CFI_MASK, we'll have to use
a bit outside of vlan_tci.

#define VLAN_PRIO_MASK         0xe000 /* Priority Code Point */
#define VLAN_PRIO_SHIFT        13
#define VLAN_CFI_MASK          0x1000 /* Canonical Format Indicator */
#define VLAN_TAG_PRESENT       VLAN_CFI_MASK
#define VLAN_VID_MASK          0x0fff /* VLAN Identifier */
Reported-by: default avatarGertjan Hofman <gertjan_hofman@yahoo.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      05423b24
  13. 03 Sep, 2009 2 commits
  15. 01 Sep, 2009 2 commits
  17. 14 Aug, 2009 1 commit
  19. 30 May, 2009 1 commit
    • Jiri Pirko's avatar
      net: convert unicast addr list · ccffad25
      Jiri Pirko authored 
      
This patch converts unicast address list to standard list_head using
previously introduced struct netdev_hw_addr. It also relaxes the
locking. Original spinlock (still used for multicast addresses) is not
needed and is no longer used for a protection of this list. All
reading and writing takes place under rtnl (with no changes).

I also removed a possibility to specify the length of the address
while adding or deleting unicast address. It's always dev->addr_len.

The convertion touched especially e1000 and ixgbe codes when the
change is not so trivial.
Signed-off-by: default avatarJiri Pirko <jpirko@redhat.com>

 drivers/net/bnx2.c               |   13 +--
 drivers/net/e1000/e1000_main.c   |   24 +++--
 drivers/net/ixgbe/ixgbe_common.c |   14 ++--
 drivers/net/ixgbe/ixgbe_common.h |    4 +-
 drivers/net/ixgbe/ixgbe_main.c   |    6 +-
 drivers/net/ixgbe/ixgbe_type.h   |    4 +-
 drivers/net/macvlan.c            |   11 +-
 drivers/net/mv643xx_eth.c        |   11 +-
 drivers/net/niu.c                |    7 +-
 drivers/net/virtio_net.c         |    7 +-
 drivers/s390/net/qeth_l2_main.c  |    6 +-
 drivers/scsi/fcoe/fcoe.c         |   16 ++--
 include/linux/netdevice.h        |   18 ++--
 net/8021q/vlan.c                 |    4 +-
 net/8021q/vlan_dev.c             |   10 +-
 net/core/dev.c                   |  195 +++++++++++++++++++++++++++-----------
 net/dsa/slave.c                  |   10 +-
 net/packet/af_packet.c           |    4 +-
 18 files changed, 227 insertions(+), 137 deletions(-)
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ccffad25
  21. 25 May, 2009 1 commit
  23. 19 May, 2009 1 commit
    • Eric Dumazet's avatar
      net: release dst entry in dev_hard_start_xmit() · 93f154b5
      Eric Dumazet authored 
      
One point of contention in high network loads is the dst_release() performed
when a transmited skb is freed. This is because NIC tx completion calls
dev_kree_skb() long after original call to dev_queue_xmit(skb).

CPU cache is cold and the atomic op in dst_release() stalls. On SMP, this is
quite visible if one CPU is 100% handling softirqs for a network device,
since dst_clone() is done by other cpus, involving cache line ping pongs.

It seems right place to release dst is in dev_hard_start_xmit(), for most
devices but ones that are virtual, and some exceptions.

David Miller suggested to define a new device flag, set in alloc_netdev_mq()
(so that most devices set it at init time), and carefuly unset in devices
which dont want a NULL skb->dst in their ndo_start_xmit().

List of devices that must clear this flag is :

- loopback device, because it calls netif_rx() and quoting Patrick :
    "ip_route_input() doesn't accept loopback addresses, so loopback packets
     already need to have a dst_entry attached."
- appletalk/ipddp.c : needs skb->dst in its xmit function

- And all devices that call again dev_queue_xmit() from their xmit function
(as some classifiers need skb->dst) : bonding, vlan, macvlan, eql, ifb, hdlc_fr
Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      93f154b5
  25. 18 May, 2009 1 commit
  27. 25 Apr, 2009 1 commit
    • Jay Vosburgh's avatar
      vlan: update vlan carrier state for admin up/down · adc667e8
      Jay Vosburgh authored 
      
	Currently, the VLAN event handler does not adjust the VLAN
device's carrier state when the real device or the VLAN device is set
administratively up or down.

	The following patch adds a transfer of operating state from the
real device to the VLAN device when the real device is administratively
set up or down, and sets the carrier state up or down during init, open
and close of the VLAN device.

	This permits observers above the VLAN device that care about the
carrier state (bonding's link monitor, for example) to receive updates
for administrative changes by more closely mimicing the behavior of real
devices.
Signed-off-by: default avatarJay Vosburgh <fubar@us.ibm.com>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
      adc667e8
  29. 21 Apr, 2009 1 commit
  31. 17 Apr, 2009 1 commit
  33. 05 Mar, 2009 1 commit
    • David S. Miller's avatar
      vlan: Fix vlan-in-vlan crashes. · 9d40bbda
      David S. Miller authored 
      
As analyzed by Patrick McHardy, vlan needs to reset it's
netdev_ops pointer in it's ->init() function but this
leaves the compat method pointers stale.

Add a netdev_resync_ops() and call it from the vlan code.

Any other driver which changes ->netdev_ops after register_netdevice()
will need to call this new function after doing so too.

With help from Patrick McHardy.
Tested-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9d40bbda
  35. 08 Jan, 2009 1 commit
  37. 25 Dec, 2008 1 commit
  39. 20 Nov, 2008 1 commit
  41. 04 Nov, 2008 1 commit
  43. 29 Oct, 2008 1 commit
  45. 21 Sep, 2008 1 commit
  47. 11 Sep, 2008 1 commit
  49. 22 Jul, 2008 1 commit
  51. 17 Jul, 2008 1 commit
    • David S. Miller's avatar
      netdev: Allocate multiple queues for TX. · e8a0464c
      David S. Miller authored 
      
alloc_netdev_mq() now allocates an array of netdev_queue
structures for TX, based upon the queue_count argument.

Furthermore, all accesses to the TX queues are now vectored
through the netdev_get_tx_queue() and netdev_for_each_tx_queue()
interfaces.  This makes it easy to grep the tree for all
things that want to get to a TX queue of a net device.

Problem spots which are not really multiqueue aware yet, and
only work with one queue, can easily be spotted by grepping
for all netdev_get_tx_queue() calls that pass in a zero index.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e8a0464c
  53. 15 Jul, 2008 4 commits
  55. 14 Jul, 2008 1 commit
  57. 09 Jul, 2008 1 commit
  59. 08 Jul, 2008 6 commits