Skip to content

GitLab

Switch branch/tag
  1. 08 Sep, 2009 1 commit
  3. 23 Jul, 2009 1 commit
  5. 24 Jun, 2009 3 commits
  7. 16 Jun, 2009 1 commit
  9. 11 Jun, 2009 2 commits
  11. 23 May, 2009 1 commit
  13. 07 Apr, 2009 1 commit
  15. 31 Mar, 2009 1 commit
  17. 30 Mar, 2009 1 commit
    • Alexey Dobriyan's avatar
      proc 2/2: remove struct proc_dir_entry::owner · 99b76233
      Alexey Dobriyan authored 
      Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      99b76233
  19. 27 Mar, 2009 1 commit
  21. 25 Mar, 2009 1 commit
  23. 02 Feb, 2009 1 commit
  25. 30 Jan, 2009 1 commit
  27. 27 Jan, 2009 1 commit
  29. 22 Jan, 2009 1 commit
  31. 09 Jan, 2009 3 commits
    • Takashi Sato's avatar
      filesystem freeze: add error handling of write_super_lockfs/unlockfs · c4be0c1d
      Takashi Sato authored 
      
Currently, ext3 in mainline Linux doesn't have the freeze feature which
suspends write requests.  So, we cannot take a backup which keeps the
filesystem's consistency with the storage device's features (snapshot and
replication) while it is mounted.

In many case, a commercial filesystem (e.g.  VxFS) has the freeze feature
and it would be used to get the consistent backup.

If Linux's standard filesystem ext3 has the freeze feature, we can do it
without a commercial filesystem.

So I have implemented the ioctls of the freeze feature.
I think we can take the consistent backup with the following steps.
1. Freeze the filesystem with the freeze ioctl.
2. Separate the replication volume or create the snapshot
   with the storage device's feature.
3. Unfreeze the filesystem with the unfreeze ioctl.
4. Take the backup from the separated replication volume
   or the snapshot.

This patch:

VFS:
Changed the type of write_super_lockfs and unlockfs from "void"
to "int" so that they can return an error.
Rename write_super_lockfs and unlockfs of the super block operation
freeze_fs and unfreeze_fs to avoid a confusion.

ext3, ext4, xfs, gfs2, jfs:
Changed the type of write_super_lockfs and unlockfs from "void"
to "int" so that write_super_lockfs returns an error if needed,
and unlockfs always returns 0.

reiserfs:
Changed the type of write_super_lockfs and unlockfs from "void"
to "int" so that they always return 0 (success) to keep a current behavior.
Signed-off-by: default avatarTakashi Sato <t-sato@yk.jp.nec.com>
Signed-off-by: default avatarMasayuki Hamaguchi <m-hamaguchi@ys.jp.nec.com>
Cc: <xfs-masters@oss.sgi.com>
Cc: <linux-ext4@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Alasdair G Kergon <agk@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      c4be0c1d
    • Dave Kleikamp's avatar
      jfs: remove xtLookupList() · fec1878f
      Dave Kleikamp authored 
      
xtLookupList() was a more generalized version of xtLookup() with a
nastier interface.  Its only caller, extHint(), is actually better
suited to using xtLookup() than xtLookupList().  This also lets us
remove the definition of lxd_t, an obnoxious packed structure that was
only used in-memory.
Signed-off-by: default avatarDave Kleikamp <shaggy@linux.vnet.ibm.com>
      fec1878f
    • Dave Kleikamp's avatar
      jfs: clean up a dangling comment · da9c138e
      Dave Kleikamp authored 
      
viro cleaned up an hlist hack, but left a comment where it no longer
belongs.  Combine the old comment with his new one.
Signed-off-by: default avatarDave Kleikamp <shaggy@linux.vnet.ibm.com>
      da9c138e
  33. 05 Jan, 2009 1 commit
  35. 31 Dec, 2008 1 commit
  37. 16 Dec, 2008 1 commit
  39. 13 Nov, 2008 1 commit
  41. 23 Oct, 2008 2 commits
  43. 21 Oct, 2008 1 commit
  45. 13 Oct, 2008 1 commit
  47. 26 Jul, 2008 2 commits
  49. 25 Jul, 2008 1 commit
  51. 10 Jun, 2008 1 commit
  53. 28 May, 2008 1 commit
  55. 21 May, 2008 1 commit
  57. 13 May, 2008 1 commit
  59. 12 May, 2008 1 commit
  61. 29 Apr, 2008 1 commit
  63. 19 Apr, 2008 1 commit
  65. 05 Mar, 2008 1 commit

Menu

Help