- 01 May, 2008 2 commits
-
-
Jared Hulbert authored
Adding the ability to get a physical address from point() in addition to virtual address. This physical address is required for XIP of userspace code from flash. Signed-off-by:
Jared Hulbert <jaredeh@gmail.com> Reviewed-by:
Jörn Engel <joern@logfs.org> Acked-by:
Nicolas Pitre <nico@cam.org> Acked-by:
Greg Ungerer <gerg@uclinux.org> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
David Woodhouse authored
To support NFS export, we need to know the parent inode of directories. Rather than growing the jffs2_inode_cache structure, share space with the nlink field -- which was always set to 1 for directories anyway. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 23 Apr, 2008 1 commit
-
-
David Woodhouse authored
We haven't seen bugs in this for a while now, since the rewrite. No need to be _quite_ so verbose... Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 22 Apr, 2008 1 commit
-
-
David Woodhouse authored
Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 03 Feb, 2008 1 commit
-
-
Robert P. J. Day authored
Signed-off-by:
Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by:
Adrian Bunk <bunk@kernel.org>
-
- 28 Nov, 2007 1 commit
-
-
Alexey Korolev authored
If we ask it to map 'len' bytes of the device, don't compare against some other number and whine that it's different. That's a little silly. Signed-off-by:
Alexey Korolev <akorolev@infradead.org> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 21 Nov, 2007 1 commit
-
-
David Woodhouse authored
We were failing to check the data CRC on data nodes on non-writebuffered flash, which led to "interesting" behaviour on unclean shutdowns. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 23 Sep, 2007 1 commit
-
-
Andy Lowe authored
Fix a couple of instances in JFFS2 where the unpoint() routine is being called with the wrong length in cases where the point() routine truncated a request. Signed-off-by:
Andy Lowe <alowe@mvista.com> Signed-off-by:
Nicolas Pitre <nico@cam.org> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 02 Aug, 2007 2 commits
-
-
David Woodhouse authored
Debugging the hardware problems in OLPC trac #1905 would be a whole lot easier if the correct node offsets were printed for the offending nodes. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
David Woodhouse authored
Otherwise they'll never actually get garbage-collected. Noted by Jonathan Larmour. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 10 Jul, 2007 1 commit
-
-
David Woodhouse authored
Convert many spaces to tabs; one or two other minor cosmetic fixes. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 05 Jul, 2007 1 commit
-
-
David Woodhouse authored
Debugging the hardware problems in OLPC trac #1905 would be a whole lot easier if the correct node offsets were printed for the offending nodes. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 04 Jul, 2007 1 commit
-
-
David Woodhouse authored
We should have stopped returning 1 from read_dnode() to indicate failure. We can just mark the damn thing obsolete immediately. But I missed a case where we don't. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 03 Jul, 2007 1 commit
-
-
David Woodhouse authored
We should have stopped returning 1 from read_dnode() to indicate failure. We can just mark the damn thing obsolete immediately. But I missed a case where we don't. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 29 Jun, 2007 1 commit
-
-
David Woodhouse authored
Otherwise they'll never actually get garbage-collected. Noted by Jonathan Larmour. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 01 Jun, 2007 2 commits
-
-
David Woodhouse authored
We should keep the mdata node with higher version number, not just the one we happen to find latest. Doh. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
Artem Bityutskiy authored
If we have already read enough bytes, no need to call read_more(). Signed-off-by:
Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 07 May, 2007 2 commits
-
-
David Woodhouse authored
Fixing at least a couple more bugs in the process. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
David Woodhouse authored
We attempted to insert new nodes into the tree by just using rb_replace_node to let them replace an earlier node which they completely overlapped. However, that could place the new node into the wrong place in the tree, since its start could be node only before the start of the victim, but before the node _before_ the victim in the tree (if that previous node actually ends _after_ the new node, thus isn't entirely overlapped and wasn't itself chosen to be the victim). Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 06 May, 2007 1 commit
-
-
David Woodhouse authored
The original code would remember, during the first pass over the tree, a suitable place to start the insertion from when we eventually come to add a new node. The optimisation was broken, and we sometimes ended up inserting a new node in the wrong place because we started the insertion from the wrong point. Just ditch the optimisation and start the insertion from the root of the tree, for now. I'll try it again when I'm feeling cleverer. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 05 May, 2007 1 commit
-
-
David Woodhouse authored
This fixes a problem Artem found with the integck test tool -- we weren't correctly keeping track of the 'overlap' flag in some cases, which led to the nodes being played back in an incorrect order and file corruption. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 25 Apr, 2007 2 commits
-
-
David Woodhouse authored
This should never happen unless there's corruption on the medium and the actual data nodes go missing. But the failure mode (an oops when we assume the fragtree isn't empty and go looking for its last node) isn't useful. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
David Woodhouse authored
In particular, remove the bit in the LICENCE file about contacting Red Hat for alternative arrangements. Their errant IS department broke that arrangement a long time ago -- the policy of collecting copyright assignments from contributors came to an end when the plug was pulled on the servers hosting the project, without notice or reason. We do still dual-license it for use with eCos, with the GPL+exception licence approved by the FSF as being GPL-compatible. It's just that nobody has the right to license it differently. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 24 Apr, 2007 2 commits
-
-
Joakim Tjernlund authored
No need to check for all-zero header since the header cannot be zero due to other checks. Replace the all-zero header check in readinode.c with a check for the magic word. Signed-off-by:
Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
David Woodhouse authored
We originally used to read every node and allocate a jffs2_tmp_dnode_info structure for each, before processing them in (reverse) version order and discarding the ones which are obsoleted by later nodes. With huge logfiles, this behaviour caused memory problems. For example, a file involved in OLPC trac #1292 has 1822391 nodes, and would cause the XO machine to run out of memory during the first stage of read_inode(). Instead of just inserting nodes into a tree in version order as we find them, we now put them into a tree in order of their offset within the file, which allows us to immediately discard nodes which are completely obsoleted. We don't use a full tree with 'fragments' pointing to the real data structure, as we do in the normal fragtree. We sort only on the start address, and add an 'overlapped' flag to the tmp_dnode_info to indicate that the node in question is (partially) overlapped by another. When the scan is complete, we start at the end of the file, adding each node to a real fragtree as before. Where the node is non-overlapped, we just add it (it doesn't matter that it's not the latest version; there is no overlap). When the node at the end of the tree _is_ overlapped, we sort it and all its overlapping nodes into version order and then add them to the fragtree in that order. This 'early discard' reduces the peak allocation of tmp_dnode_info structures from 1.8M to a mere 62872 (3.5%) in the degenerate case referenced above. This version of the patch also correctly rememembers the highest node version# seen for an inode when it's scanned. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 17 Apr, 2007 1 commit
-
-
Artem Bityutskiy authored
In read inode we have an optimization which prevents one min. I/O unit (e.g. NAND page) to be read more then once. Namely, at the beginning we do not know which node type we read, so we read so we assume we read the directory entry, because it has the smallest node header. When we read it, we read up to the next min. I/O unit, just because if later we'll need to read more, we already have this data. If it turns out to be that the node is not directory entry, and we need more data, and we did not read it because it sits in the next min. I/O unit, we read the whole next (or several next) min. I/O unit(s). And if it happens to be that we read a data node, and we've read part of its data, we calculate partial CRC. So if later we need to check data CRC, we'll only read the rest of the data from further min. I/O units and continue CRC checking. This code was a bit messy and buggy. The bug was that it assumed relatively large min. I/O unit, so that the largest node header could overlap only one min. I/O unit boundary. This parch clean-ups the code a bit and fixes this bug. The patch was not tested on flash with small min. I/O unit, like NOR-ECC, nut it was tested on NAND with 512 bytes NAND page, so it at least does not break NAND. It was also tested with mtdram so it should not break NOR. Signed-off-by:
Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 09 Mar, 2007 1 commit
-
-
David Woodhouse authored
Due to a poor choice of CRC32 seed, a node header which is all zeroes would pass the CRC32 check. Explicitly check for this case, and treat it as we do a CRC failure. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 10 Dec, 2006 1 commit
-
-
Yan Burman authored
Replace kmalloc+memset with kzalloc Signed-off-by:
Yan Burman <burman.yan@gmail.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 02 Jul, 2006 1 commit
-
-
KaiGai Kohei authored
jffs2_clear_acl() which releases acl caches allocated by kmalloc() was defined but it was never called. Thus, we faced to the risk of memory leaking. This patch plugs jffs2_clear_acl() into jffs2_do_clear_inode(). It ensures to release acl cache when inode is cleared. Signed-off-by:
KaiGai Kohei <kaigai@ak.jp.nec.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 27 Jun, 2006 1 commit
-
-
KaiGai Kohei authored
If xattr_ref is associated with an orphan inode_cache on filesystem mounting, those xattr_refs are not released even if this inode_cache is released. This patch enables to call jffs2_xattr_delete_inode() for such a irregular inode_cachde too. Signed-off-by:
KaiGai Kohei <kaigai@ak.jp.nec.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 18 Jun, 2006 1 commit
-
-
David Woodhouse authored
Also, make sure dirents are marked REF_UNCHECKED when we 'discover' them through eraseblock summary. Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 17 Jun, 2006 1 commit
-
-
David Woodhouse authored
Especially when summary code is used, we can have in-memory data structures referencing certain nodes without them actually being readable on the flash. Discard the nodes gracefully in that case, rather than triggering a BUG(). Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 13 May, 2006 2 commits
-
-
KaiGai Kohei authored
This patch can reduce 4-byte of memory usage per inode_cache. [4/10] jffs2-xattr-v5.1-04-remove_ilist_from_ic.patch Signed-off-by:
KaiGai Kohei <kaigai@ak.jp.nec.com>
-
KaiGai Kohei authored
This attached patches provide xattr support including POSIX-ACL and SELinux support on JFFS2 (version.5). There are some significant differences from previous version posted at last December. The biggest change is addition of EBS(Erase Block Summary) support. Currently, both kernel and usermode utility (sumtool) can recognize xattr nodes which have JFFS2_NODETYPE_XATTR/_XREF nodetype. In addition, some bugs are fixed. - A potential race condition was fixed. - Unexpected fail when updating a xattr by same name/value pair was fixed. - A bug when removing xattr name/value pair was fixed. The fundamental structures (such as using two new nodetypes and exclusion mechanism by rwsem) are unchanged. But most of implementation were reviewed and updated if necessary. Espacially, we had to change several internal implementations related to load_xattr_datum() to avoid a potential race condition. [1/2] xattr_on_jffs2.kernel.version-5.patch [2/2] xattr_on_jffs2.utils.version-5.patch Signed-off-by:
KaiGai Kohei <kaigai@ak.jp.nec.com> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 21 Apr, 2006 1 commit
-
-
David Woodhouse authored
Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 11 Apr, 2006 1 commit
-
-
Randy Dunlap authored
Fix printk format warnings in jffs2. Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
David Woodhouse <dwmw2@infradead.org>
-
- 09 Mar, 2006 1 commit
-
-
Atsushi Nemoto authored
Fix some bugs in mtd/jffs2 on 64bit platform. The MEMGETBADBLOCK/MEMSETBADBLOCK ioctl are not listed in compat_ioctl.h. And some variables in jffs2 are declared as uint32_t but used to hold size_t values. Signed-off-by:
Atsushi Nemoto <anemo@mba.ocn.ne.jp> Cc: Thomas Gleixner <tglx@linutronix.de> Acked-by:
David Woodhouse <dwmw2@infradead.org> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
- 07 Nov, 2005 2 commits
-
-
Jesper Juhl authored
This is the fs/ part of the big kfree cleanup patch. Remove pointless checks for NULL prior to calling kfree() in fs/. Signed-off-by:
Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Thomas Gleixner authored
Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-
- 06 Nov, 2005 1 commit
-
-
Artem B. Bityutskiy authored
Simplify the debugging code further. Update the TODO list Signed-off-by:
Artem B. Bityutskiy <dedekind@infradead.org> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de>
-