Skip to content

GitLab

Switch branch/tag
  1. 29 Sep, 2008 3 commits
  3. 18 Jul, 2008 2 commits
  5. 04 Jul, 2008 1 commit
  7. 02 Jul, 2008 4 commits
  9. 23 Jun, 2008 1 commit
    • Benny Halevy's avatar
      nfsd: make nfs4xdr WRITEMEM safe against zero count · 13b1867c
      Benny Halevy authored 
      
WRITEMEM zeroes the last word in the destination buffer
for padding purposes, but this must not be done if
no bytes are to be copied, as it would result
in zeroing of the word right before the array.

The current implementation works since it's always called
with non zero nbytes or it follows an encoding of the
string (or opaque) length which, if equal to zero,
can be overwritten with zero.

Nevertheless, it seems safer to check for this case.
Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      13b1867c
  11. 25 Apr, 2008 1 commit
  13. 23 Apr, 2008 1 commit
  15. 15 Feb, 2008 1 commit
  17. 01 Feb, 2008 2 commits
    • Frank Filz's avatar
      nfsd: Allow AIX client to read dir containing mountpoints · 406a7ea9
      Frank Filz authored 
      
This patch addresses a compatibility issue with a Linux NFS server and
AIX NFS client.

I have exported /export as fsid=0 with sec=krb5:krb5i
I have mount --bind /home onto /export/home
I have exported /export/home with sec=krb5i

The AIX client mounts / -o sec=krb5:krb5i onto /mnt

If I do an ls /mnt, the AIX client gets a permission error. Looking at
the network traceIwe see a READDIR looking for attributes
FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID. The response gives a
NFS4ERR_WRONGSEC which the AIX client is not expecting.

Since the AIX client is only asking for an attribute that is an
attribute of the parent file system (pseudo root in my example), it
seems reasonable that there should not be an error.

In discussing this issue with Bruce Fields, I initially proposed
ignoring the error in nfsd4_encode_dirent_fattr() if all that was being
asked for was FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID, however,
Bruce suggested that we avoid calling cross_mnt() if only these
attributes are requested.

The following patch implements bypassing cross_mnt() if only
FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID are called. Since there
is some complexity in the code in nfsd4_encode_fattr(), I didn't want to
duplicate code (and introduce a maintenance nightmare), so I added a
parameter to nfsd4_encode_fattr() that indicates whether it should
ignore cross mounts and simply fill in the attribute using the passed in
dentry as opposed to it's parent.
Signed-off-by: default avatarFrank Filz <ffilzlnx@us.ibm.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      406a7ea9
    • J. Bruce Fields's avatar
      nfsd: Fix handling of negative lengths in read_buf() · ca2a05aa
      J. Bruce Fields authored 
      
The length "nbytes" passed into read_buf should never be negative, but
we check only for too-large values of "nbytes", not for too-small
values.  Make nbytes unsigned, so it's clear that the former tests are
sufficient.  (Despite this read_buf() currently correctly returns an xdr
error in the case of a negative length, thanks to an unsigned
comparison with size_of() and bounds-checking in kmalloc().  This seems
very fragile, though.)
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      ca2a05aa
  19. 09 Oct, 2007 3 commits
  21. 26 Jul, 2007 1 commit
  23. 17 Jul, 2007 3 commits
  25. 08 May, 2007 1 commit
  27. 16 Feb, 2007 3 commits
  29. 14 Feb, 2007 1 commit
  31. 26 Jan, 2007 1 commit
    • NeilBrown's avatar
      [PATCH] knfsd: Fix type mismatch with filldir_t used by nfsd · a0ad13ef
      NeilBrown authored 
      
nfsd defines a type 'encode_dent_fn' which is much like 'filldir_t' except
that the first pointer is 'struct readdir_cd *' rather than 'void *'.  It
then casts encode_dent_fn points to 'filldir_t' as needed.  This hides any
other type mismatches between the two such as the fact that the 'ino' arg
recently changed from ino_t to u64.

So: get rid of 'encode_dent_fn', get rid of the cast of the function type,
change the first arg of various functions from 'struct readdir_cd *' to
'void *', and live with the fact that we have a little less type checking
on the calling of these functions now.  Less internal (to nfsd) checking
offset by more external checking, which is more important.

Thanks to Gabriel Paubert <paubert@iram.es> for discovering this and
providing an initial patch.
Signed-off-by: default avatarGabriel Paubert <paubert@iram.es>
Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a0ad13ef
  33. 13 Dec, 2006 1 commit
  35. 20 Oct, 2006 4 commits
  37. 04 Oct, 2006 5 commits
  39. 03 Oct, 2006 1 commit