Skip to content

GitLab

Switch branch/tag
  1. 24 May, 2010 1 commit
  3. 15 Sep, 2009 1 commit
  5. 05 Dec, 2008 2 commits
  7. 26 May, 2008 1 commit
    • Roland Dreier's avatar
      IB/ipath: Avoid test_bit() on u64 SDMA status value · e8ffef73
      Roland Dreier authored 
      
Gabriel C <nix.or.die@googlemail.com> pointed out that when the x86
bitops are updated to operate on unsigned long, the code in
sdma_abort_task() will produce warnings:

    drivers/infiniband/hw/ipath/ipath_sdma.c: In function 'sdma_abort_task':
    drivers/infiniband/hw/ipath/ipath_sdma.c:267: warning: passing argument 2 of 'constant_test_bit' from incompatible pointer type

and so on, because it uses test_bit() to operation on a u64 value
(returned by ipath_read_kref64() for a hardware register).

Fix up these warnings by converting the test_bit() operations to &ing
with appropriate symbolic defines of the bits within the hardware
register.  This has the benign side-effect of making the code more
self-documenting as well.
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      e8ffef73
  9. 13 May, 2008 2 commits
    • Roland Dreier's avatar
      IB/ipath: Change ipath_devdata.ipath_sdma_status to be unsigned long · f018c7e1
      Roland Dreier authored 
      
Andrew Morton <akpm@linux-foundation.org> pointed out that bitops
should take an unsigned long * arg.  However, the ipath driver was
doing bitops on struct ipath_devdata.ipath_sdma_status, which is u64.
Change this member to unsigned long to avoid tons of warnings when x86
fixes the bitops to take unsigned long * instead of void *.

Also, change the IPATH_SDMA_RUNNING and IPATH_SDMA_SHUTDOWN bit
numbers to 30 and 31 (instead of 62 and 63) so that we're not setting
another booby trap for someone who tries to make ipath work on a
32-bit architecture.
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      f018c7e1
    • Pavel Emelyanov's avatar
      IB/ipath: Make ipath_portdata work with struct pid * not pid_t · 40d97692
      Pavel Emelyanov authored 
      The official reason is "with the presence of pid namespaces in the
kernel using pid_t-s inside one is no longer safe."

But the reason I fix this right now is the following:

About a month ago (when 2.6.25 was not yet released) there still was a
one last caller of a to-be-deprecated-soon function find_pid() - the
kill_proc() function, which in turn was only used by nfs callback
code.

During the last merge window, this last caller was finally eliminated
by some NFS patch(es) and I was about to finally kill this kill_proc()
and find_pid(), but found, that I was late and the kill_proc is now
called from the ipath driver since commit 58411d1c

 ("IB/ipath: Head of
Line blocking vs forward progress of user apps").

So here's a patch that fixes this code to use struct pid * and (!)
the kill_pid routine.
Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      40d97692
  11. 07 May, 2008 1 commit
    • Dave Olson's avatar
      IB/ipath: Need to always request and handle PIO avail interrupts · e2ab41ca
      Dave Olson authored 
      
Now that we always use PIO for vl15 on 7220, we could get stuck forever
if we happened to run out of PIO buffers from the verbs code, because
the setup code wouldn't run; the interrupt was also ignored if SDMA was
supported.  We also have to reduce the pio update threshold if we have
fewer kernel buffers than the existing threshold.

Clean up the initialization a bit to get ordering safer and more
sensible, and use the existing ipath_chg_kernavail call to do init,
rather than doing it separately.

Drop unnecessary clearing of pio buffer on pio parity error.

Drop incorrect updating of pioavailshadow when exitting freeze mode
(software state may not match chip state if buffer has been allocated
and not yet written).

If we couldn't get a kernel buffer for a while, make sure we are
in sync with hardware, mainly to handle the exitting freeze case.
Signed-off-by: default avatarDave Olson <dave.olson@qlogic.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      e2ab41ca
  13. 19 Apr, 2008 1 commit
  15. 17 Apr, 2008 18 commits
  17. 11 Mar, 2008 1 commit
  19. 25 Jan, 2008 12 commits