Skip to content

GitLab

Switch branch/tag
  1. 03 Apr, 2009 12 commits
  3. 18 Mar, 2009 2 commits
  5. 17 Mar, 2009 1 commit
  7. 07 Jan, 2009 1 commit
  9. 29 Sep, 2008 6 commits
  11. 18 Jul, 2008 2 commits
  13. 04 Jul, 2008 1 commit
  15. 02 Jul, 2008 4 commits
  17. 23 Jun, 2008 1 commit
    • Benny Halevy's avatar
      nfsd: make nfs4xdr WRITEMEM safe against zero count · 13b1867c
      Benny Halevy authored 
      
WRITEMEM zeroes the last word in the destination buffer
for padding purposes, but this must not be done if
no bytes are to be copied, as it would result
in zeroing of the word right before the array.

The current implementation works since it's always called
with non zero nbytes or it follows an encoding of the
string (or opaque) length which, if equal to zero,
can be overwritten with zero.

Nevertheless, it seems safer to check for this case.
Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      13b1867c
  19. 25 Apr, 2008 1 commit
  21. 23 Apr, 2008 1 commit
  23. 15 Feb, 2008 1 commit
  25. 01 Feb, 2008 2 commits
    • Frank Filz's avatar
      nfsd: Allow AIX client to read dir containing mountpoints · 406a7ea9
      Frank Filz authored 
      
This patch addresses a compatibility issue with a Linux NFS server and
AIX NFS client.

I have exported /export as fsid=0 with sec=krb5:krb5i
I have mount --bind /home onto /export/home
I have exported /export/home with sec=krb5i

The AIX client mounts / -o sec=krb5:krb5i onto /mnt

If I do an ls /mnt, the AIX client gets a permission error. Looking at
the network traceIwe see a READDIR looking for attributes
FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID. The response gives a
NFS4ERR_WRONGSEC which the AIX client is not expecting.

Since the AIX client is only asking for an attribute that is an
attribute of the parent file system (pseudo root in my example), it
seems reasonable that there should not be an error.

In discussing this issue with Bruce Fields, I initially proposed
ignoring the error in nfsd4_encode_dirent_fattr() if all that was being
asked for was FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID, however,
Bruce suggested that we avoid calling cross_mnt() if only these
attributes are requested.

The following patch implements bypassing cross_mnt() if only
FATTR4_RDATTR_ERROR and FATTR4_MOUNTED_ON_FILEID are called. Since there
is some complexity in the code in nfsd4_encode_fattr(), I didn't want to
duplicate code (and introduce a maintenance nightmare), so I added a
parameter to nfsd4_encode_fattr() that indicates whether it should
ignore cross mounts and simply fill in the attribute using the passed in
dentry as opposed to it's parent.
Signed-off-by: default avatarFrank Filz <ffilzlnx@us.ibm.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      406a7ea9
    • J. Bruce Fields's avatar
      nfsd: Fix handling of negative lengths in read_buf() · ca2a05aa
      J. Bruce Fields authored 
      
The length "nbytes" passed into read_buf should never be negative, but
we check only for too-large values of "nbytes", not for too-small
values.  Make nbytes unsigned, so it's clear that the former tests are
sufficient.  (Despite this read_buf() currently correctly returns an xdr
error in the case of a negative length, thanks to an unsigned
comparison with size_of() and bounds-checking in kmalloc().  This seems
very fragile, though.)
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
      ca2a05aa
  27. 09 Oct, 2007 3 commits
  29. 26 Jul, 2007 1 commit
  31. 17 Jul, 2007 1 commit