1. 25 Dec, 2008 10 commits
  2. 30 Oct, 2008 1 commit
  3. 28 Oct, 2008 1 commit
    • Steve French's avatar
      [CIFS] Reduce number of socket retries in large write path · edf1ae40
      Steve French authored
      
      CIFS in some heavy stress conditions cifs could get EAGAIN
      repeatedly in smb_send2 which led to repeated retries and eventually
      failure of large writes which could lead to data corruption.
      
      There are three changes that were suggested by various network
      developers:
      
      1) convert cifs from non-blocking to blocking tcp sendmsg
      (we left in the retry on failure)
      2) change cifs to not set sendbuf and rcvbuf size for the socket
      (let tcp autotune the buffer sizes since that works much better
      in the TCP stack now)
      3) if we have a partial frame sent in smb_send2, mark the tcp
      session as invalid (close the socket and reconnect) so we do
      not corrupt the remaining part of the SMB with the beginning
      of the next SMB.
      
      This does not appear to hurt performance measurably and has
      been run in various scenarios, but it definately removes
      a corruption that we were seeing in some high stress
      test cases.
      Acked-by: default avatarShirish Pargaonkar <shirishp@us.ibm.com>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      edf1ae40
  4. 22 Sep, 2008 1 commit
  5. 29 Jul, 2008 1 commit
  6. 15 Apr, 2008 1 commit
  7. 12 Feb, 2008 1 commit
  8. 07 Feb, 2008 1 commit
  9. 13 Nov, 2007 1 commit
    • Steve French's avatar
      [CIFS] Fix buffer overflow if server sends corrupt response to small · 133672ef
      Steve French authored
      request
      
      In SendReceive() function in transport.c - it memcpy's
      message payload into a buffer passed via out_buf param. The function
      assumes that all buffers are of size (CIFSMaxBufSize +
      MAX_CIFS_HDR_SIZE) , unfortunately it is also called with smaller
      (MAX_CIFS_SMALL_BUFFER_SIZE) buffers.  There are eight callers
      (SMB worker functions) which are primarily affected by this change:
      
      TreeDisconnect, uLogoff, Close, findClose, SetFileSize, SetFileTimes,
      Lock and PosixLock
      
      CC: Dave Kleikamp <shaggy@austin.ibm.com>
      CC: Przemyslaw Wegrzyn <czajnik@czajsoft.pl>
      Acked-by: default avatarJeff Layton <jlayton@redhat.com>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      133672ef
  10. 18 Oct, 2007 1 commit
  11. 30 Aug, 2007 1 commit
  12. 12 Jul, 2007 1 commit
  13. 09 Jul, 2007 1 commit
  14. 06 Jul, 2007 1 commit
  15. 05 Mar, 2007 1 commit
  16. 07 Dec, 2006 3 commits
  17. 11 Aug, 2006 4 commits
  18. 31 May, 2006 1 commit
  19. 26 Feb, 2006 1 commit
  20. 23 Jan, 2006 1 commit
  21. 12 Jan, 2006 1 commit
  22. 12 Dec, 2005 1 commit
  23. 02 Dec, 2005 1 commit
  24. 29 Nov, 2005 1 commit
  25. 16 Nov, 2005 1 commit
  26. 11 Oct, 2005 1 commit