- 11 Jul, 2008 10 commits
-
-
Andre Noll authored
Rename it to sb_start to make sure all users have been converted. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
As BLOCK_SIZE_BITS is 10 and MD_NEW_SIZE_SECTORS(2 * x) = 2 * NEW_SIZE_BLOCKS(x), the return value of calc_dev_sboffset() doubles. Fix up all three callers accordingly. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Number of sectors is the preferred unit for sizes of raid devices, so change calc_dev_size() so that it returns this unit instead of the number of 1K blocks. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Changing the internal representations of sizes of raid devices from 1K blocks to sector counts (512B units) is desirable because it allows to get rid of many divisions/multiplications and unnecessary casts that are present in the current code. This patch is a first step in this direction. It replaces the old 1K-based "size" argument of update_size() by "num_sectors" and fixes up its two callers. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Neil Brown authored
do_md_stop check the number of active users before allowing the array to be stopped. Two problems: 1/ it assumes the request is coming through an open file descriptor (via ioctl) so it allows for that. This is not always the case. 2/ it doesn't do the check it the array hasn't been activated. This is not good for cases when we use an inactive array to hold some devices in a container. Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
The current code copies a signed int from user space, converts it to unsigned and passes the unsigned value to find_rdev_nr() which expects a signed value. Simply pass the signed value from user space directly. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
If alloc_page() fails, ENOMEM is a more suitable error value than EINVAL. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
The only caller of sb_equal() tests the return value against zero, so it's OK to return the negated return value of memcmp(). Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
- 10 Jul, 2008 2 commits
-
-
Max Krasnyansky authored
The scenario goes like this. App stops reading from tun/tap. TX queue gets full and driver does netif_stop_queue(). App closes fd and TX queue gets flushed as part of the cleanup. Next time the app opens tun/tap and starts reading from it but the xoff state is not cleared. We're stuck. Normally xoff state is cleared when netdev is brought up. But in the case of persistent devices this happens only during initial setup. The fix is trivial. If device is already up when an app opens it we clear xoff state and that gets things moving again. Signed-off-by:
Max Krasnyansky <maxk@qualcomm.com> Tested-by:
Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Dan Williams authored
Remove the dubious attempt to prefer 'compute' over 'read'. Not only is it wrong given commit c337869d (md: do not compute parity unless it is on a failed drive), but it can trigger a BUG_ON in handle_parity_checks5(). Cc: <stable@kernel.org> Signed-off-by:
Dan Williams <dan.j.williams@intel.com> Signed-off-by:
Neil Brown <neilb@suse.de>
-
- 09 Jul, 2008 3 commits
-
-
Ihar Hrachyshka authored
Fixing unaligned memory access on the blackfin architecture. Signed-off-by:
Ihar Hrachyshka <ihar.hrachyshka@promwad.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Luis Carlos Cobo authored
If a mesh or ad-hoc interface is brought up and later it is replaced by managed interface, the managed interface will keep transmitting the beacons that were configured for the former interface. This patch fixes that behaviour. Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Ivo van Doorn authored
As soon as init_registers() was called, the rt2400/rt2500 would start raising beacondone interrupts. Since this is highly premature since no beacons were provided yet, we should initialize the synchronization register to 0. This will make all drivers initialize it to 0 regardless if they are raising beacondone interrupts or not, since it only makes sense to have it completely disabled. Signed-off-by:
Ivo van Doorn <IvDoorn@gmail.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
- 08 Jul, 2008 7 commits
-
-
Steve Wise authored
The change to iwch_provider.c in commit f4e91eb4 ("IB: convert struct class_device to struct device") undid the fix done in commit 7f049f2f ("RDMA/cxgb3: Hold rtnl_lock() around ethtool get_drvinfo call"). It removed the calls to rtnl_lock() that serialized the iw_cxgb3 ethtool ops calls into the cxgb3 driver. This locking is needed to avoid messing up the internal state of the cxgb3 driver. Signed-off-by:
Steve Wise <swise@opengridcomputing.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Takashi Iwai authored
On 2.6.26-rc9, the commit 05946bce ("fsl_diu_fb: fix build with CONFIG_PM=y, plus fix some warnings") breaks its previous fix f969c567 ("fsl-diu-db: compile fix") This patch reverts the broken part. Signed-off-by:
Takashi Iwai <tiwai@suse.de> Acked-by:
Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Bartlomiej Zolnierkiewicz authored
Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Sergei Shtylyov authored
The driver uses completely bogus rounding formula for calculating period from the IDECLK frequency which gives one-off period values (e.g. 11 ns with 100 MHz IDECLK) which in turn can lead to overclocked IDE transfer timings. Actually, rounding is just wrong in this case, so use a mere division for a safe result. While at it, also: - give 'ide_palm_clk' variable a more suitable name; - get rid of the useless 'ideclkp' variable; - drop the LISP stype 'p' postfix from the 'clkp' variable's name. :-) Signed-off-by:
Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: mcherkashin@ru.mvista.com Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Bartlomiej Zolnierkiewicz authored
Add __ide_default_irq() inline helper and use it instead of ide_default_irq() in ide-probe.c and ns87415.c (all host drivers except IDE PCI ones always setup hwif->irq so it is enough to check only for I/O bases 0x1f0 and 0x170). This fixes post-2.6.25 regression since ide_default_irq() define could shadow ide_default_irq() inline. Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Ville Syrjala authored
HP OmniBook 500's DSDT code changes the HID of the FIR device from NSC6001 to HWPC224 when run under an "NT" operating system. Add the new ID to the pnp device id table. Signed-off-by:
Ville Syrjala <syrjala@sci.fi> Signed-off-by:
Samuel Ortiz <samuel@sortiz.org> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Wang Chen authored
1. dma should be freed when dma2 request fail. 2. dma2 should be freed too when device close. Signed-off-by:
Wang Chen <wangchen@cn.fujitsu.com> Signed-off-by:
Samuel Ortiz <samuel@sortiz.org> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
- 07 Jul, 2008 11 commits
-
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
- Remove superfluous parentheses. - Make format string match the type of the variable that is printed. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
In case pers->run() succeeds but creating the bitmap fails, we print an error message stating that pers->run() has failed. Print this message only if pers->run() really failed. Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Andre Noll authored
Signed-off-by:
Andre Noll <maan@systemlinux.org> Signed-off-by:
Neil Brown <neilb@suse.de>
-
Michael Buesch authored
On embedded devices we must not route the interrupts through the PCI core, if our host-bus is not PCI. Reported-by:
Steve Brown <sbrown@cortland.com> Signed-off-by:
Michael Buesch <mb@bu3sch.de> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Firat Birlik authored
I would like to inform you of our zd1211 based usb wifi adapter (AirTies WUS-201), which works with the zd1211rw driver with the following device id definition. Signed-off-by:
Daniel Drake <dsd@gentoo.org> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Darren Jenkins authored
Coverity CID: 2265 NEGATIVE_RETURNS "rate" is of an unsigned type, and the code requires a signed type. The following patch makes it so. Signed-off-by:
Darren Jenkins <darrenrjenkins@gmailcom> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
John W. Linville authored
This corrects this kernel.org bug: http://bugzilla.kernel.org/show_bug.cgi?id=9701 Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
- 06 Jul, 2008 2 commits
-
-
Philipp Zabel authored
The pxa27x DMA controller defaults to 64-bit alignment. This caused the SCR reads to fail (and, depending on card type, error out) when card->raw_scr was not aligned on a 8-byte boundary. For performance reasons all scatter-gather addresses passed to pxamci_request should be aligned on 8-byte boundaries, but if this can't be guaranteed, byte aligned DMA transfers in the have to be enabled in the controller to get correct behaviour. Signed-off-by:
Philipp Zabel <philipp.zabel@gmail.com> Signed-off-by:
Pierre Ossman <drzeus@drzeus.cx> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Linus Torvalds authored
This reverts commit e8721549. Andrey Borzenkov reports that it resulted in a totally hung machine for him when loading the OHCI driver. Extensive netconsole capture with SysRq output shows that modprobe gets stuck in ohci_hub_status_data() when probing and enabling the OHCI controller, see for example http://lkml.org/lkml/2008/7/5/236 for an analysis. The problem appears to be an interrupt flood triggered by the commit that gets reverted, and Andrey confirmed that the revert makes things work for him again. Reported-and-tested-by:
Andrey Borzenkov <arvidjaar@mail.ru> Acked-by:
Alan Stern <stern@rowland.harvard.edu> Acked-by:
David Brownell <david-b@pacbell.net> Cc: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
- 05 Jul, 2008 5 commits
-
-
Tejun Heo authored
Commit ea0c62f7 tried to clear all bits in irq_stat but it didn't actually achieve that as irq_stat was anded with port_map right after read. This patch makes ahci driver always use the unmasked value to clear irq_status. While at it, add explanation on the peculiarities of ahci IRQ clearing. This was spotted by Linus Torvalds. Signed-off-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Bartlomiej Zolnierkiewicz authored
Holding ide_lock for ide_release_dma_engine() call is unnecessary and triggers WARN_ON(irqs_disabled()) in dma_free_coherent(). Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Bartlomiej Zolnierkiewicz authored
Fix ide_unregister() to work for ports with no devices attached to them. Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
Bartlomiej Zolnierkiewicz authored
class->dev_release is called by device_release() iff dev->release is not present so ide_port_class_release() is never called and the last hwif->gendev reference is not dropped. Fix it by removing ide_port_class_release() and get_device() call from ide_register_port() (device_create_drvdata() takes a hwif->gendev reference anyway). This patch fixes hang on wait_for_completion(&hwif->gendev_rel_comp) in ide_unregister() reported by Pavel Machek. Cc: Pavel Machek <pavel@suse.cz> Cc: "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Greg KH <greg@kroah.com> Signed-off-by:
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-
H. Peter Anvin authored
Some Dell laptops enter resume with apparent garbage in the segment descriptor registers (almost certainly the result of a botched transition from protected to real mode.) The only way to clean that up is to enter protected mode ourselves and clean out the descriptor registers. This fixes resume on Dell XPS M1210 and Dell D620. Reference: http://bugzilla.kernel.org/show_bug.cgi?id=10927 Signed-off-by:
H. Peter Anvin <hpa@zytor.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: pm list <linux-pm@lists.linux-foundation.org> Cc: Len Brown <lenb@kernel.org> Signed-off-by:
Ingo Molnar <mingo@elte.hu> Tested-by:
Kirill A. Shutemov <kirill@shutemov.name> Signed-off-by:
Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by:
Ingo Molnar <mingo@elte.hu>
-