• Siddha, Suresh B's avatar
    [PATCH] mm: fix a race condition under SMC + COW · 4ce072f1
    Siddha, Suresh B authored
    Failing context is a multi threaded process context and the failing
    sequence is as follows.
    
    One thread T0 doing self modifying code on page X on processor P0 and
    another thread T1 doing COW (breaking the COW setup as part of just
    happened fork() in another thread T2) on the same page X on processor P1.
    T0 doing SMC can endup modifying the new page Y (allocated by the T1 doing
    COW on P1) but because of different I/D TLB's, P0 ITLB will not see the new
    mapping till the flush TLB IPI from P1 is received.  During this interval,
    if T0 executes the code created by SMC it can result in an app error (as
    ITLB still points to old page X and endup executing the content in page X
    rather than using the content in page Y).
    
    Fix this issue by first clearing the PTE and flushing it, before updating
    it with new entry.
    
    Hugh sayeth:
    
      I was a bit sceptical, in the habit of thinking that Self Modifying Code
      must look such issues itself: but I guess there's nothing it can ...
    4ce072f1
memory.c 71 KB