• Hisashi Hifumi's avatar
    ext3: fdatasync should skip metadata writeout when overwriting · 3d61f75e
    Hisashi Hifumi authored
    Currently fdatasync is identical to fsync in ext3.
    
    I think fdatasync should skip journal flush in data=ordered and
    data=writeback mode when it overwrites to already-instantiated blocks on
    HDD.  When I_DIRTY_DATASYNC flag is not set, fdatasync should skip journal
    writeout because this indicates only atime or/and mtime updates.
    
    Following patch is the same approach of ext2's fsync code(ext2_sync_file).
    
    I did a performance test using the sysbench.
    
    #sysbench --num-threads=128 --max-requests=50000 --test=fileio --file-total-size=128G
    --file-test-mode=rndwr --file-fsync-mode=fdatasync run
    
    The result on ext3 was:
    
    	-2.6.24
    	Operations performed:  0 Read, 50080 Write, 59600 Other = 109680 Total
    	Read 0b  Written 782.5Mb  Total transferred 782.5Mb  (12.116Mb/sec)
    	  775.45 Requests/sec executed
    
    	Test execution summary:
    	    total time:                          64.5814s
    	    total number of events:              50080
    	    total time taken by event ...
    3d61f75e
fsync.c 2.71 KB